Repetitive daily quests are a legitimate method of generating significant cashflow. Players who spend several hours a day doing daily quests can often generate 100 per hour. Many players have funded the purchase of their elite flying mounts solely through doing daily quests. Another trick for higher level players is to do level 70 dailies as a level 75-77. If you have a hankering to get a Netherdrake, for instance, and you already have a fast flying mount (which is a pre-requisite for the drake), you will find your mid-70s an ideal time to go get that drake. Not only will the quests be a lot easier to do at level 75+, but the dailies will pay about 1200 as you level rep, and you'll get XP along the way to boot (albeit not as much as quests in Northrend.) So if you're looking for a break from the grind of leveling to 80, and want to kick back, spank some level 69s and make some decent money along the way, doing lower level dailies can be a fun way to make some extra cash.
The Hearthstone has a cooldown of 30 minutes, but there’s a guild perk called Hasty Hearth that shaves the time by half, giving you a strong incentive to join a guild. Yes, even if it’s some random guild that invites you without warning. It may feel odd to join people you don’t know, but if they have Hasty Hearth (and most guilds do), joining can save you a lot of legwork.
The greatest potential for going from 25,000g to the gold cap of 214748g is transferring servers. However, this also presents the greatest risk and needs the most preparation. First off, transferring costs money. If you go to a server, transferring back as soon as the cool down is up is expensive and impractical. You should look for a server that you can stay on for at least 6 months to a year before transferring back with your huge profit. However, the maximum amount of gold that a max character can transfer is only 20,000. Therefore, you need to purchase goods that are going to net you the most profit when you go to sell them on the new server's auction house. Primarily, these are enchanting mats, but can also be BoE epics depending on the two servers. Before making a risky decision such as transferring, consult the questions below.
You can earn a decent amount of XP by doing Herbalism or mining. Any zone works but I prefer Sholazar Basin as a lot of the mobs are not aggressive and the mobs are spread out so you will find a lot of herbs and ore that you don’t have to fight for. It is possible to make about a level every hour by doing this, or a level every 30-40 minutes with rest XP.
For this farm we're taking it all the way back to eastern kingdoms.  We're going to be killing the purespring elementals in the purespring cavern for the item essence of water.  Essence of water is a semi-rare drop that goes for a shocking 252g per piece.  The caveat is that it doesn't drop all too often, but is still worth the trouble.  I wasn't getting TOO many of these, but I was still making bank with them.  The essences are used to create the old-world illusions, so they do have some inherent value.  Simply patrol the area and kill as many elementals as your heart desires.  It's a really cool and fun farm that can be done on autopilot.  Usually there is noone patrolling the spot.
The majority of you (myself included) don't find farming fun. You don't have 20+ hours to burn each week on an activity that you find dull and mindless. Because of these things alone, you may try but you'll never be able to commit to doing this week in, week out, and this is why you'll fail. Repost after repost, without seeing success, you'll simply call it, and be just another guy who saw a transmog youtuber, tried to get into the transmog business, and quit after a day/week/month.
If you are already at Level 110, you will probably have a number of different Legendary items to choose from (if you do not have any Legendary items, simply skip this section). While their special effects stop working at Level 116, until then, they can be a powerful bonus to help you level up quickly. These are our Legendary recommendations for leveling as a Protection Warrior in Battle for Azeroth:
Applebot, Baidu, Bing, Google, Yandex, AdonS-B, adrammelei, AfroDeus, agent_dash, Alexbaffu, Alfamonk, aureolebigben, bahar161, camoril, chalup, chemick13, cxmz, dagasis, Daimarra, dalrok, enemydown28, Failedcupid, filigar, Fulgerstyle, gcats, gesar, godenemy, hamfist, Haregarwas, hhumas, HolyCross, jamz01, JordynMarie, kahlbanor, KaseyStat, lance2355, lexd, megayota2012, mrgheb, Naulii, nGxDox, oiMiKeyvx, Petkooo, Rasalgul, Screamer63, SDWinchester, seonju, SourPatchBruhs, stevendph, tarciryan, thaihigh, thepoonbaron, Tiger267, tijeffz, trotgar, ValeteZ, volkanx05, xingudi
Any item with a grey name is considered vendor trash or poor quality. White items have some use such as tradeskills, spell reagents or reputation raisers, so you may want to check to see if they're worth more than the vendor price. Keep your eyes out for regular quality weapons, as even the worst of these tend to sell for several silver, or several gold at high level. Always check the tooltip for the vendor price before discarding anything. Also, white (or even grey) shoulder armor under level 20 sells regularly on the auction house, mainly because there is nothing better available at that level.

Legion's game design set up BFA to feel bad when weapons were made to be removed but player were not to retain their benefits in some way. BFA will set up the next expansion in the same way with the removal the azerite necklace leaving the next expansion in a similar place where classes will feel empty and no actual amount of character progression has occurred over the next two years.
To give you some perspective I leveled both a LF Ret Paladin and BE Rogue (so one started from level 20 and the other from level 1). I focused on getting the achievements I was missing for the Loremaster, so not the most efficient route by any means. I was using full enchanted heirlooms (minus the ring) and the WoW-Pro addon though, as well as having War Mode turned on all the way.
There are addons for ElvUI on Curse, but unlike the other addons on this list, ElvUI itself can has to be downloaded separately. Despite this, it is probably the most useful in terms of UI customization. ElvUI is a complete UI overhaul that allows you to fix many of the basic customization issues that the original WoW UI has. The big drawback to ElvUI is that it is a bit of a time investment when you first download it. It takes a while to get used to, and you’ll have to take the time out to fully customize your UI. This can feel vastly different from other addons that are mostly set immediately once you’ve installed them. If you’re willing to put in that time though, this can be a really effective tool in organizing your menus, and having a better visual experience playing WoW. With this addon, you won’t need some of the other ones, such as Bagnon, which ElvUI already has built in.

The best way to collect AP is through world quests, a system that allows players to complete menial tasks to earn moderate rewards. A finite amount of AP spawns on the map through these quests — generally at least 2,000 a day. I’ve likely done most of these quests close to 20 times in the course of preparing my various characters in the 45 days since the expansion launched. In some cases, I’ve replayed them as many as 50 times.

Heirlooms. At the bare minimum you make sure all the armor pieces upgraded to 110, since this is the lion's share of your experience increase. Neck and Ring upgrades are secondary, but still important due to being able to enchant them. Trinkets can't be enchanted, but you'll want them at max as well, if only to save time by not having to worry about replacing them as you level.
The Death Adder Hatchling is still one of the expensive farmable pets today, simply because it requires quite a bit of luck to get it. But still, chances to get this pet can be increased if you know what to do. Therefore, whether you want this pet for your collection, or to sell it, here’s what you need to do: Requirements: Minimum level 90; TomTom ... Read More »
Alchemy is a great profession for gold-making as the main outputs are consumed on use, this means that there will always be demand for new potions and flasks. The old world recipes are also very profitable. Sadly I don’t have Legion alchemy so I can’t personally help you. The best guide I was able to find on the internet is this video guide by Ninja Kuma.
While not as powerful as it was before 7.3, this transmog spot is a good area to amass a large number of BOE greens that generally fly around the 35 – 42 area.  It's popularity stemming from the amount of items that drop (and the potential value of those items) rather than the quality of each drop itself. Generally drops from these farms can take a while to sell even when using my TSM posting style.  However if your low on transmog stock this can be an awesome area to hit every now and then.
A dungeon should take about half an hour to 45 minutes, that is reasonable. What did we do to Maw of Souls because it was by far the fastest dungeon to spam run for AP? Nerfed its yield. Same happened to dungeons. Except instead of nerfing the XP, they adjusted the clear speed to justify the experience a bit more. Is it perfect? Nah, a lot of dungeons aren't even that long with updates. At most a clear takes 5 mins more.
Let’s consider the fact, that the token price is rising again with the Virtual Blizzcon Ticket and possible Addon-Announcements for Blizzard Games. The reason the token is so cheap right now is the fact, that a lot of players bought Tokens for real money at the Shop. The more tokens are ingame, the less gold they cost. Supply and demand is the keyword here.